Repository navigation
fix(bundler): import.meta.url and esm wrapper fixes
#23803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b906ced
cjs import.meta.url fix, esm __toESM wrapper fix
dylan-conway 3996f71
more inline
dylan-conway f3e69ba
Merge remote-tracking branch 'origin/main' into dylan/import-meta-url…
Jarred-Sumner 98ef8cd
Update bundler_npm.test.ts
Jarred-Sumner 3eca45d
Add comprehensive bundler tests for CJS/ESM interop with __toESM
1ee7f0a
Fix invalid test and add documentation for input_module_type
4cf9c30
Fix test to properly demonstrate the __toESM fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Deriving module type from export kind can misclassify ESM modules with no exports.
Mapping
.none -> .unknownrisks under-detecting ESM “importer” files that have only imports (or justimport.meta) and no exports. In such casesinput_module_typewould be.unknown, and the printer would omit the, 1flag to__toESM, breaking CJS→ESM interop for those importers.import/exportsyntax or parser/module mode.🏁 Script executed:
Length of output: 64485
🏁 Script executed:
Length of output: 5379
Output:
🏁 Script executed:
Length of output: 6299
🏁 Script executed:
Length of output: 6299
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 1087
🏁 Script executed:
Length of output: 2907
🏁 Script executed:
Length of output: 3685
🏁 Script executed:
Length of output: 2027
Fix the exports_kind derivation to detect ESM-only importers.
The bug is real: files with only ESM imports (no exports, no top-level await) have
exports_kind=.none, which maps tomodule_type=.unknownviatoModuleType(). This occurs whenmodule_typeis preset and the fix path at Parser.zig:1080 is skipped.The fix should use the existing
has_es_module_syntaxsignal (which correctly includes import keyword detection per P.zig:2014) instead of checking only exports and await. Change Parser.zig line 1017–1018 from:to:
This ensures ESM-only importers are classified as
.esmrather than.unknown, preserving the CJS→ESM interop flag.🤖 Prompt for AI Agents