Repository navigation

Fix: Make SQL connection string parsing more sensible - #22260

Merged

Jarred-Sumner merged 83 commits into

mainfrom

ali/fix-sql-connection-string-parsing

Sep 9, 2025

Merged

Fix: Make SQL connection string parsing more sensible#22260
Jarred-Sumner merged 83 commits into
mainfrom
ali/fix-sql-connection-string-parsing

Commits on Aug 30, 2025
- refactor: Fix Bun.SQL options parsing to separate adapter detection and prevent env variable mixing
  
  authored and
  cirospaciari
  committed
  5a1f894
- fix: Correct MYSQL_URL protocol detection in adapter inference
  
  authored and
  cirospaciari
  committed
  666aea0
- test: Add comprehensive MySQL port defaulting tests
  
  authored and
  cirospaciari
  committed
  6f75091
- fix: Infer adapter from environment variable names when protocol is missing
  
  authored and
  cirospaciari
  committed
  669e022
- refactor: Simplify adapter inference to prioritize environment variable names over protocols
  
  authored and
  cirospaciari
  committed
  7dba454
- [autofix.ci] apply automated fixes
  
  autofix-ci[bot]
  authored and
  cirospaciari
  committed
  c19c865
- feat: Add comprehensive MySQL environment variable support
  
  authored and
  cirospaciari
  committed
  0906de4
- [autofix.ci] apply automated fixes
  
  autofix-ci[bot]
  authored and
  cirospaciari
  committed
  bb89714
- test: Add SSL mode verification for TLS environment variable tests
  
  authored and
  cirospaciari
  committed
  952300f
- feat: Add comprehensive adapter-protocol validation with conflict detection
  
  authored and
  cirospaciari
  committed
  5128275
- Complete SQL options parsing refactor
  
  authored and
  cirospaciari
  committed
  cdeefff
- Fix SQL options precedence: explicit options override URL parameters
  
  authored and
  cirospaciari
  committed
  0bc8e6b
- [autofix.ci] apply automated fixes
  
  autofix-ci[bot]
  authored and
  cirospaciari
  committed
  251268f
- fix linter
  cirospaciari
  committed
  79996d1
- fix parseurlForAdapter
  cirospaciari
  committed
  f0174a7
- fix coderabbit issues
  cirospaciari
  committed
  0009922
- fix error
  cirospaciari
  committed
  d4a15c4
- fix more
  cirospaciari
  committed
  f456566
- dont discard tls
  cirospaciari
  committed
  98399e1
- revert shared for now
  alii
  committed
  a98c72e
Commits on Sep 2, 2025
- fix: redo connection parsing logic
  alii
  committed
  c99dfab
- normalize url protocol for parsing
  alii
  committed
  562732d
- missing TLS_MYSQL_DATABASE_URL when no adapter is specified in options
  alii
  committed
  b6a923f
- enhance connection details parsing to include adapter detection and improve environment variable handling
  alii
  committed
  50b3b6e
- refactor getConnectionDetailsFromEnvironment to streamline adapter detection and enhance environment variable handling
  alii
  committed
  ab3d771
- fix tests
  alii
  committed
  747576d
- get more tests to pass
  alii
  committed
  a02583c
Commits on Sep 3, 2025
- cleanup
  alii
  committed
  72fd476
- enhance SQL connection handling by introducing OptionsWithDefinedAdapter type and improving URL protocol management
  alii
  committed
  40b41c2
- fix: all tests passing
  alii
  committed
  1e7a3a7
- refactor parseConnectionDetailsFromOptionsOrEnvironment to improve SQLite URL handling and streamline adapter detection
  alii
  committed
  9203d57
- expect :memory: for blank path
  alii
  committed
  75f139e
- significant cleanup work
  alii
  committed
  a4a58ed
- satisfy typescript
  alii
  committed
  5d90887
- tidier
  alii
  committed
  5cb76d4
- mariadb should have its own case
  alii
  committed
  cf3f0c7
- default to sslMode.disable
  alii
  committed
  32943dd
- undo meaningless changes
  alii
  committed
  9c5bd46
- test should have a timeout
  alii
  committed
  ed8ce4f
- this should not have been reverted
  alii
  committed
  8289b1b
- tests are passing but could do with a cleanup
  alii
  committed
  b8ec02e
- [autofix.ci] apply automated fixes
  autofix-ci[bot]
  authored
  36fc3dc
- refactor SQLite URL handling and connection options parsing for clarity and efficiency
  alii
  committed
  d9522d2
- Merge branch 'ali/fix-sql-connection-string-parsing' of github.com:oven-sh/bun into ali/fix-sql-connection-string-parsing
  alii
  committed
  a2fc0d5
- change
  alii
  committed
  6fae93d
- smaller
  alii
  committed
  ba96b16
- tidier
  alii
  committed
  3052718
- make sqlite special case easier to understand
  alii
  committed
  421a6b8
- fix connection string parsing url when adapter is not sqlite, but a non-parsable sqlite url was passed
  alii
  committed
  f756a3e
- skip unix socket tests on windows
  alii
  committed
  5d66a20
- Empty filename should default to :memory:
  alii
  committed
  c2180b7
- mariadb case
  alii
  committed
  3d9de4d
- [autofix.ci] apply automated fixes
  autofix-ci[bot]
  authored
  bfe6166
- Revert launch.json
  alii
  committed
  0588916
- fix: Make passing tests actually pass with better env resetting
  alii
  committed
  5d92536
- make sql errors much less noisy (omit undefined properties by default)
  alii
  committed
  6ac21ca
- fix: Satisfy oxlint declaration merging
  alii
  committed
  c6e735c
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  36fa997
- fallback tls value
  alii
  committed
  6b149c4
- use `await using` in a test
  alii
  committed
  520a9b5
Commits on Sep 4, 2025
- try ci
  alii
  committed
  2d1817d
- revert tls changes and try ci
  alii
  committed
  677eefe
- see if changes are related
  alii
  committed
  6cd8d93
- debug
  alii
  committed
  e382508
- dont listen on mysql.sock in precedence test
  alii
  committed
  b04a3f9
- Fix Unix domain socket cleanup on listener.stop()
  Claude Bot
  committed
  e0714d9
- fix: should work with unix requires the path to exist
  alii
  committed
  382f687
Commits on Sep 5, 2025
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  884f2f3
- [autofix.ci] apply automated fixes
  autofix-ci[bot]
  authored
  4a52927
- fix: deprecate .ssl in the options since it's an alias of tls
  alii
  committed
  e292748
Commits on Sep 6, 2025
- update docs & dont use regex for checking protocol
  alii
  committed
  d03b861
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  ba1e261
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  4ca6dcc
- ci: try run this on windows
  alii
  committed
  6ed13e9
- cleanup test
  alii
  committed
  4372d30
- remove Bun.listen changes for now
  alii
  committed
  cefe202
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  c3129d3
- changes + unlink
  alii
  committed
  32a6a90
Commits on Sep 8, 2025
- small cleaning in harness
  alii
  committed
  34648f2
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  ff91fc1
- changes to types
  alii
  committed
  db15759
- skip tls-sql.test.ts when no connection string secrets locally
  alii
  committed
  c691df7
Commits on Sep 9, 2025
- Merge branch 'main' into ali/fix-sql-connection-string-parsing
  alii
  authored
  2c85900

Commits

Commits on Aug 30, 2025

Commits on Sep 2, 2025

Commits on Sep 3, 2025

Commits on Sep 4, 2025

Commits on Sep 5, 2025

Commits on Sep 6, 2025

Commits on Sep 8, 2025

Commits on Sep 9, 2025