Skip to content

Unskip more bundler tests - #22244

Merged
Jarred-Sumner merged 2 commits into
mainfrom
jarred/unskip-more
Aug 30, 2025
Merged

Jarred-Sumner merged 2 commits into
mainfrom
jarred/unskip-more

Conversation

@Jarred-Sumner

@Jarred-Sumner Jarred-Sumner commented Aug 30, 2025 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

How did you verify your code works?

Summary by CodeRabbit

  • Tests
    • Enabled multiple previously skipped bundler and esbuild test cases by removing todo flags, increasing test suite coverage.
    • Broadened cross-platform applicability by removing OS-specific gating in certain tests, ensuring they run consistently across environments.
    • Activated additional scenarios around resolve/load behavior, dead code elimination, package.json handling, and extra edge cases.
    • No impact on runtime behavior or public APIs; changes are limited to test execution and reliability.

@coderabbitai

coderabbitai Bot commented Aug 30, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

Removed todo flags and OS-specific gating in several test suites to enable previously skipped tests across bundler and esbuild test files. Adjusted imports to remove platform gating where present. No production code or public API changes.

Changes

Cohort / File(s) Summary of Changes
Bundler Plugin tests
test/bundler/bundler_plugin.test.ts
Removed multiple todo: true markers to activate five plugin-related tests.
Esbuild DCE tests
test/bundler/esbuild/dce.test.ts
Enabled one DCE test by removing todo: true.
Esbuild default tests and gating
test/bundler/esbuild/default.test.ts
Dropped OS-specific gating imports; enabled several tests by removing todo: true; removed platform gating for require shim tests.
Esbuild extra tests
test/bundler/esbuild/extra.test.ts
Enabled two tests by removing todo: true and a comment implying browser require absence.
Esbuild package.json self-import tests
test/bundler/esbuild/packagejson.test.ts
Enabled four self-import tests by removing todo: true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit thumps the test bench floor,
“Wake up, specs!”—we skip no more.
Flags undone, the suites all run,
Cross OS paths now join as one.
With whiskers twitching, green lights glow—
Hop, hop, hop, the passes flow! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 684f7ec and 95fc4ec.

📒 Files selected for processing (5)
  • test/bundler/bundler_plugin.test.ts (0 hunks)
  • test/bundler/esbuild/dce.test.ts (0 hunks)
  • test/bundler/esbuild/default.test.ts (1 hunks)
  • test/bundler/esbuild/extra.test.ts (0 hunks)
  • test/bundler/esbuild/packagejson.test.ts (0 hunks)
💤 Files with no reviewable changes (4)
  • test/bundler/esbuild/packagejson.test.ts
  • test/bundler/esbuild/dce.test.ts
  • test/bundler/esbuild/extra.test.ts
  • test/bundler/bundler_plugin.test.ts
🔇 Additional comments (1)
test/bundler/esbuild/default.test.ts (1)

3-3: Verified harness exports osSlashes
test/harness.ts defines and exports osSlashes, and there are no remaining isMacOS or isMusl references in default.test.ts.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jarred/unskip-more

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@robobun

robobun commented Aug 30, 2025 •

Copy link
Copy Markdown
Collaborator
Updated 5:50 PM PT - Aug 29th, 2025

❌ @autofix-ci[bot], your commit 95fc4ec has 2 failures in Build #24285:


🧪   To try this PR locally:

bunx bun-pr 22244

That installs a local version of the PR into your bun-22244 executable, so you can run:

bun-22244 --bun

@Jarred-Sumner
Jarred-Sumner merged commit 822445d into main Aug 30, 2025
58 of 60 checks passed
@Jarred-Sumner
Jarred-Sumner deleted the jarred/unskip-more branch August 30, 2025 01:16
@coderabbitai coderabbitai Bot mentioned this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants