Repository navigation
fix(tls) fix ciphers - #21545
Merged
Merged
fix(tls) fix ciphers#21545
Conversation
Collaborator
|
Updated 4:09 PM PT - Aug 4th, 2025
❌ @cirospaciari, your commit 3caf845 has 5 failures in
🧪 To try this PR locally: bunx bun-pr 21545That installs a local version of the PR into your bun-21545 --bun |
cirospaciari
marked this pull request as ready for review
August 2, 2025 00:45
|
Is this PR merged into Bun v1.2.0? Since in my case it has not solved the connection problem. |
robobun
added a commit
that referenced
this pull request
Sep 7, 2026
…hers An SSLConfig built without a `ciphers` option falls back to the list assigned through `tls.DEFAULT_CIPHERS`, in the one native place every TLS consumer goes through (tls.createServer, https.createServer, createSecureContext, Bun.serve, Bun.listen). #21545 added this fallback in SSLConfig.fromJS and the bindgen port (#23169) dropped it, so only tls.connect (which passes the default explicitly) still honoured it. A default list with no TLS 1.2 cipher left raises the protocol floor to TLS 1.3, like Node's configSecureContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses same ciphers than node.js for compatibility and do the same error checking on empty ciphers
Fixes #9425
Fixes #21518
Fixes #19859
Fixes #18980
You can see more about redis ciphers here https://redis.io/docs/latest/operate/rs/security/encryption/tls/ciphers/ this should fix redis related ciphers issues
How did you verify your code works?
Tests