ci: instrument being able to run leaksanitizer#21142
Merged
Merged
Conversation
Collaborator
|
Updated 2:44 AM PT - Sep 19th, 2025
❌ @nektro, your commit 6125c16 has 3 failures in
🧪 To try this PR locally: bunx bun-pr 21142That installs a local version of the PR into your bun-21142 --bun |
Contributor
Author
result running on empty file |
pfgithub
reviewed
Jul 18, 2025
Contributor
Author
|
maybe its better to stay in a branch until at least an empty file passes |
|
|
||
| pub fn deinit(this: *Define) void { | ||
| var diter = this.dots.valueIterator(); | ||
| while (diter.next()) |key| this.allocator.free(key.*); |
Collaborator
There was a problem hiding this comment.
this will almost certainly crash something. we usually don't clone the defines.
Contributor
Author
There was a problem hiding this comment.
this.dots is a bun.StringHashMap([]DotDefine). this particular loop is only freeing those slices
This was referenced Sep 25, 2025
Closed
This was referenced Oct 3, 2025
This was referenced Oct 12, 2025
Closed
This was referenced Oct 21, 2025
This was referenced Oct 31, 2025
This was referenced Nov 15, 2025
9 tasks
1 task
This was referenced Jan 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests not in
test/no-validate-leaksan.txtwill run with leaksanitizer in CIleaks documented in
test/leaksan.suppwill not cause a test failure-- notes about leaksanitizer
mallocnotfreed