Skip to content

Change fish path addition command #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 1 commit into from
Jul 5, 2022
Merged

Change fish path addition command #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ if test $(basename $SHELL) == "fish"; then
IS_BUN_AUTO_UPDATE="true" SHELL="fish" $exe completions >/dev/null 2>&1
if test -f $HOME/.config/fish/config.fish; then
echo -e "\n# bun\nset -Ux BUN_INSTALL \"$bun_install\"" >>"$HOME/.config/fish/config.fish"
echo -e "set -px --path PATH \"$bin_dir\"\n" >>"$HOME/.config/fish/config.fish"
echo -e "fish_add_path \"$bin_dir\"\n" >>"$HOME/.config/fish/config.fish"

@halostatue halostatue Jul 5, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these two changes are not quite equivalent.

By default, fish_add_path modifies $fish_user_paths, a universal variable. If you just want to modify $PATH by default, this should be done with fish_add_path -P ….

echo ""
echo -e "$Dim Added \"$bin_dir\" to \$PATH in \"\~/.config/fish/config.fish\"$Color_Off"
echo ""
Expand All @@ -131,7 +131,7 @@ if test $(basename $SHELL) == "fish"; then
echo "Manually add the directory to your \$HOME/.config/fish/config.fish (or similar)"
echo ""
echo -e " $BWhite set -Ux BUN_INSTALL \"$bun_install\"$Color_Off"
echo -e " $BWhite set -px --path PATH \"$bin_dir\"$Color_Off"
echo -e " $BWhite fish_add_path \"$bin_dir\"$Color_Off"
echo ""
fi
elif
Expand Down