Repository navigation
Conversation
|
Updated 4:21 PM PT - Oct 20th, 2025
❌ @alii, your commit a45c263 has 1 failures in
🧪 To try this PR locally: bunx bun-pr 19940That installs a local version of the PR into your bun-19940 --bun |
There was a problem hiding this comment.
Most of my comments are nitpicks, but the use of reinterpret_cast instead of static_cast for casting JSC::JSGlobalObject* to Zig::GlobalObject* is a safety issue. If there's any doubt whatsoever about whether a JSC::JSGlobalObject is also an instance of Zig::GlobalObject, use jsCast for an assertion failure (including in release builds) or jsDynamicCast for returning nullptr if the cast fails. Otherwise, static_cast is fine.
|
This assertion failure in test-worker-message-port-transfer-terminate is interesting: https://buildkite.com/bun/bun/builds/18199#01974255-d25e-4706-8891-290500bfd29b/2013-2014 Trying to repro |
190n
left a comment
There was a problem hiding this comment.
Comments + I'll figure out the assertion failure
| const flakyResults = []; | ||
| const failedResults = []; | ||
| const maxAttempts = 1 + (parseInt(options["retries"]) || 0); | ||
| const defaultMaxAttempts = 1 + (parseInt(options["retries"]) || 0); |
There was a problem hiding this comment.
we should revert this before merge
|
Closing as:
|
What does this PR do?
Fixes #19924
Fixes #13218
How did you verify your code works?
third party test (but will likely need to do more since there are worker related changes)