Skip to content

Revert "compat(http2) validations and some behavior fixes (#19558)" - #19616

Merged
Jarred-Sumner merged 1 commit into
mainfrom
ben/revert-19558
May 13, 2025
Merged

Jarred-Sumner merged 1 commit into
mainfrom
ben/revert-19558

Conversation

@190n

@190n 190n commented May 13, 2025 •

Copy link
Copy Markdown
Contributor

What does this PR do?

This reverts PR #19558. It makes test-http2-client-upload.js fail in debug and flaky in release:

Mismatched noop function calls. Expected exactly 1, actual 0.
    at <anonymous> (/Users/ben/code/bun/workers/test/js/node/test/parallel/test-http2-client-upload.js:48:31)
    at onceWrapper (unknown)
    at emit (node:events:139:22)
    at emitListeningNextTick (node:net:1338:13)

How did you verify your code works?

The test passes with the commit reverted

This reverts commit dd53294.
It makes test-http2-client-upload.js fail in debug and flaky in release.
@robobun

robobun commented May 13, 2025 •

Copy link
Copy Markdown
Collaborator
Updated 5:52 PM PT - May 12th, 2025

❌ @190n, your commit f7b75cf has 1 failures in Build #16536:


🧪   To try this PR locally:

bunx bun-pr 19616

That installs a local version of the PR into your bun-19616 executable, so you can run:

bun-19616 --bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants