compat(http2) validations and some behavior fixes

src/bun.js/api/bun/h2_frame_parser.zig

@@ -3041,9 +3041,6 @@ pub const H2FrameParser = struct {
         }
 
         const error_code = error_arg.toU32();
-        if (error_code > 13) {
-            return globalObject.throw("Invalid ErrorCode", .{});
-        }
 
         this.endStream(stream, @enumFromInt(error_code));
 
@@ -3472,6 +3469,16 @@ pub const H2FrameParser = struct {
         return stream_id;
     }
 
+    pub fn setNextStreamID(this: *H2FrameParser, _: *JSC.JSGlobalObject, callframe: *JSC.CallFrame) bun.JSError!JSValue {
+        JSC.markBinding(@src());
+        const args_list = callframe.arguments();
+        bun.debugAssert(args_list.len >= 1);
+        const stream_id_arg = args_list.ptr[0];
+        bun.debugAssert(stream_id_arg.isNumber());
+        this.lastStreamID = stream_id_arg.to(u32);
+        return .undefined;
+    }
+
     pub fn hasNativeRead(this: *H2FrameParser, _: *JSC.JSGlobalObject, _: *JSC.CallFrame) bun.JSError!JSValue {
         return JSC.JSValue.jsBoolean(this.native_socket == .tcp or this.native_socket == .tls);
     }
@@ -3562,6 +3569,7 @@ pub const H2FrameParser = struct {
         }
         return .undefined;
     }
+
     pub fn emitErrorToAllStreams(this: *H2FrameParser, globalObject: *JSC.JSGlobalObject, callframe: *JSC.CallFrame) bun.JSError!JSC.JSValue {
         JSC.markBinding(@src());
 

src/bun.js/api/h2.classes.ts

@@ -101,6 +101,10 @@ export default [
         fn: "hasNativeRead",
         length: 1,
       },
+      setNextStreamID: {
+        fn: "setNextStreamID",
+        length: 1,
+      },
       getAllStreams: {
         fn: "getAllStreams",
         length: 0,

src/bun.js/bindings/ErrorCode.ts

@@ -116,6 +116,8 @@ const errors: ErrorCodeMapping = [
   ["ERR_HTTP2_STREAM_ERROR", Error],
   ["ERR_HTTP2_TRAILERS_ALREADY_SENT", Error],
   ["ERR_HTTP2_TRAILERS_NOT_READY", Error],
+  ["ERR_HTTP2_TOO_MANY_CUSTOM_SETTINGS", Error],
+  ["ERR_HTTP2_UNSUPPORTED_PROTOCOL", Error],
   ["ERR_ILLEGAL_CONSTRUCTOR", TypeError],
   ["ERR_INCOMPATIBLE_OPTION_PAIR", TypeError],
   ["ERR_INVALID_ADDRESS", Error],

src/bun.js/bindings/NodeValidator.cpp

@@ -615,11 +615,14 @@ JSC_DEFINE_HOST_FUNCTION(jsFunction_validateBuffer, (JSC::JSGlobalObject * globa
     auto buffer = callFrame->argument(0);
     auto name = callFrame->argument(1);
 
-    if (!buffer.isCell()) return JSValue::encode(jsUndefined());
-    auto ty = buffer.asCell()->type();
+    if (!buffer.isUndefined()) {
+        if (!buffer.isCell()) return Bun::ERR::INVALID_ARG_TYPE(scope, globalObject, name, "Buffer, TypedArray, or DataView"_s, buffer);
 
-    if (JSC::typedArrayType(ty) == NotTypedArray) {
-        return Bun::ERR::INVALID_ARG_TYPE(scope, globalObject, name, "Buffer, TypedArray, or DataView"_s, buffer);
+        auto ty = buffer.asCell()->type();
+
+        if (JSC::typedArrayType(ty) == NotTypedArray) {
+            return Bun::ERR::INVALID_ARG_TYPE(scope, globalObject, name, "Buffer, TypedArray, or DataView"_s, buffer);
+        }
     }
     return JSValue::encode(jsUndefined());
 }