Repository navigation
Conversation
added 20 commits
March 14, 2025 13:41
…rowing synchronously" This reverts commit 1448e6a.
…ference to GlobalObject
Collaborator
4 tasks
Merged
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes lifetime bugs in the UDPSocket implementation. In particular, the socket would not be closed if the VM exited before it was garbage collected. This means file descriptors would leak if worker threads are rapidly created and open UDP sockets.
TODOs before merging:
ben/workersis mergedHow did you verify your code works?
TODO (this probably deserves new tests)