Implement node:crypto DiffieHellman (in native code) - #17850
Merged
Merged
Conversation
Collaborator
|
Updated 8:10 PM PT - Mar 13th, 2025
❌ @dylan-conway, your commit 41ff5b0 has 1 failures in
🧪 try this PR locally: bunx bun-pr 17850 |
Jarred-Sumner
changed the title
dylan-conway
marked this pull request as ready for review
March 12, 2025 04:16
Jarred-Sumner
pushed a commit
that referenced
this pull request
Mar 15, 2025
This was referenced Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves classes
DiffieHellman,DiffieHellmanGroup, andECDHfromnode:cryptointo c++.How did you verify your code works?
Node tests