Repository navigation
fix(ffi): make using tinycc bindings safer - #17397
Merged
Merged
Conversation
Collaborator
|
Updated 2:13 PM PT - Feb 22nd, 2025
❌ @DonIsaac, your commit c1988a0 has 1 failures in
🧪 try this PR locally: bunx bun-pr 17397 |
190n
suggested changes
Feb 17, 2025
190n
approved these changes
Feb 21, 2025
paperclover
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a wrapper to all tcc bindings to convert error codes to error unions, forcing better error handling. FFI errors should be much better handled now, though there is still room for improvement.
This PR also fixes a bus error caused by running
library.close()on any library created bycc. Turns out we cannot free relocated memory, even if JIT write protections are disabled.How did you verify your code works?
I've added tests. These changes should still be carefully reviewed.