Repository navigation
feat: load full certificate bundles from NODE_EXTRA_CA_CERTS - #16782
Merged
Merged
Conversation
ShlomoCode
marked this pull request as ready for review
February 4, 2025 05:22
ShlomoCode
marked this pull request as draft
February 5, 2025 12:56
ShlomoCode
marked this pull request as ready for review
February 5, 2025 14:44
Contributor
Author
|
@cirospaciari Would you mind taking a look? Thank you! |
cirospaciari
requested changes
Feb 6, 2025
cirospaciari
left a comment
cirospaciari
left a comment
Member
There was a problem hiding this comment.
Looks good only 1 comment, and I would ask for tests using tls module too
cirospaciari
requested changes
Feb 11, 2025
cirospaciari
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #13867
How did you verify your code works?
I added tests.
P.S.
Inspired by Node.js' approach (https://github.com/nodejs/node/blob/main/src/crypto/crypto_context.cc#L215-L236 - https://github.com/nodejs/node/blob/main/src/crypto/crypto_context.cc#L565-L577)