CSS bundling & general fixes - #16486
Merged
Merged
Conversation
Collaborator
|
Updated 1:27 PM PT - Jan 18th, 2025
✅ @zackradisic, your commit 85c1d8f has passed in 🧪 try this PR locally: bunx bun-pr 16486 |
| .{}, | ||
| ) catch bun.outOfMemory(); | ||
| }, | ||
| .css, .file, .toml, .wasm, .base64, .dataurl, .text, .bunsh => {}, |
Collaborator
There was a problem hiding this comment.
imagine embedding toml in your css
| printer_options, | ||
| &css_import.condition_import_records, | ||
| ) catch { | ||
| @panic("TODO: HANDLE THIS ERROR!"); |
Collaborator
There was a problem hiding this comment.
does this need to be a todo?
|
|
||
| while (i < text.len) { | ||
| const first_byte = text[i]; | ||
| const utf8_len = std.unicode.utf8ByteSequenceLength(first_byte) catch { |
Collaborator
There was a problem hiding this comment.
don't use std.unicode
| var i: usize = 0; | ||
| var run_start: usize = 0; | ||
|
|
||
| while (i < text.len) { |
Collaborator
There was a problem hiding this comment.
actually delete this entirely
if we need to validate unicode, use simdutf
bun.simdutf.validate.utf8
|
|
||
| // Scan for trailing characters that need to be escaped | ||
| var trailing_start = text.len; | ||
| while (trailing_start > 0) { |
Collaborator
There was a problem hiding this comment.
this loops through the entire input searching for one of 4 characters backwards? is there a way that we can avoid doing this or use simd?
Collaborator
|
merge conflicts + compiler error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?