Make AbortSignal.timeout() 6x faster - #15387
Closed
Jarred-Sumner wants to merge 17 commits into
Closed
Jarred-Sumner wants to merge 17 commits into
Jarred-Sumner wants to merge 17 commits into
Conversation
Collaborator
|
Please make abortSignal timeout works (#13302) |
Member
Merged
5 tasks
Merged
5 tasks
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes it so the only usage of
us_create_timeris the sweep and date timers used byus_loop_t. The GC timers and AbortSignal.timeout use the timer heap. This will have memory usage implications so we need to measure memory usage changes in some scenarios before merging this.This also switches the list of pending fetch() calls to shutdown to a HashMap instead of an ArrayHashMap, and swaps the multi-threaded queue of shutdowns
Stress test below gets 10x faster:
Code:
How did you verify your code works?