Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: make throwInvalidArguments use JSError #15305

Merged
merged 2 commits into from
Nov 22, 2024
Merged

zig: make throwInvalidArguments use JSError #15305

merged 2 commits into from
Nov 22, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented Nov 21, 2024

progress towards #15141

@robobun
Copy link

robobun commented Nov 21, 2024

@nektro, your commit 372f1da has 15 failures in #6550:

  • test/js/web/fetch/fetch.stream.test.ts - 1 failing on 🍎 13 x64
  • test/js/web/fetch/body-stream.test.ts - timeout on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🐧 20.04 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - timeout on 🐧 2023 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 13 x64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 x64-baseline
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 aarch64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 x64
  • test/cli/install/bun-run.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 x64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 aarch64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 x64
  • @nektro nektro marked this pull request as ready for review November 21, 2024 06:29
    @Jarred-Sumner
    Copy link
    Collaborator

    I think the test failures that are not alpine are real

    @nektro
    Copy link
    Member Author

    nektro commented Nov 21, 2024

    i believe theyre real but not caused by this pr, ive seen them fail on a handful of others
    will investigate

    @nektro nektro merged commit c3f63bc into main Nov 22, 2024
    70 checks passed
    @nektro nektro deleted the nektro-patch-64983 branch November 22, 2024 00:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants