Skip to content

Make import.meta.require act as e_require_ref - #14279

Closed
paperclover wants to merge 1 commit into
mainfrom
dave/importmetarequire-bundler
Closed

paperclover wants to merge 1 commit into
mainfrom
dave/importmetarequire-bundler

Conversation

@paperclover

@paperclover paperclover commented Oct 1, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #9416

import.meta.require will turn into the require ref

@robobun

robobun commented Oct 1, 2024 •

Copy link
Copy Markdown
Collaborator

❌ @Paperdave, your commit f2df8c1 has 15 failures in #4167:

  • test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 x64
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - timeout on 🍎 14 x64
  • test/js/node/test/parallel/fs-watch-recursive-add-file.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-add-file.test.js - 1 failing on 🍎 14 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - timeout on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 4 failing on 🍎 13 aarch64
  • test/js/node/watch/fs.watch.test.ts - timeout on 🍎 14 x64
  • test/js/node/fs/fs.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64
  • test/js/node/test/parallel/fs-watch-recursive-add-folder.test.js - 1 failing on 🍎 14 aarch64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/http/bun-serve-static.test.ts - annotation error on 🍎 13 aarch64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 13 aarch64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🍎 13 aarch64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🍎 14 aarch64
  • test/bundler/bundler_compile.test.ts - 2 failing on 🪟 x64
  • test/bundler/bundler_compile.test.ts - 2 failing on 🪟 x64-baseline
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 20.04 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 22.04 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 12 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 12 aarch64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🍎 13 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🍎 14 x64
  • @paperclover
    paperclover marked this pull request as draft October 1, 2024 20:59
    @paperclover

    paperclover commented Oct 1, 2024 •

    Copy link
    Copy Markdown
    Contributor Author

    regresses Bun.embeddedFiles test. will defer finishing this pr for later as bake is more important

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    import.meta.require is not a function error after target: "node" build

    3 participants