Repository navigation
fix(install): invalidate manifest cache on registry change - #11606
Merged
Merged
Conversation
Contributor
|
❌ @dylan-conway, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
🐧🖥 1 failing tests Linux x64
🪟💻 4 failing tests Windows x64 baseline
🪟💻 5 failing tests Windows x64
|
Collaborator
|
I think we should store the length also |
Collaborator
|
Like hash & length As another sanity check |
Collaborator
|
Let’s merge once tests run |
This was referenced Jun 6, 2024
|
Thank you very much for this fix, looking forward to the next release to adopt bun as a package manager in our day 2 day development and CI/CD pipelines. It is also highly likely that the nature of all the related issues listed in #11582 (perhaps except the #5029) lies in the behaviour that was fixed in current mr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to make sure manifests in the cache are invalidated when the registry for the package changes. This pr bumps our serialized manifest version to 3, and writes the registry hash + length to end of the file.
fixes #11582
How did you verify your code works?
Added a test that installs the same package from two registries.