Skip to content

Fix adding packages in workspaces - #11177

Merged
dylan-conway merged 34 commits into
mainfrom
dylan/fix-adding-packages-in-workspaces
May 21, 2024
Merged

dylan-conway merged 34 commits into
mainfrom
dylan/fix-adding-packages-in-workspaces

Conversation

@Jarred-Sumner

@Jarred-Sumner Jarred-Sumner commented May 19, 2024 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes bugs involving:

  • adding dependencies to workspaces
  • editing workspace package.json
  • diffing lockfiles with workspace dependencies

fixes #11064
fixes #9413
fixes #7913
fixes #7844
fixes #7547

Also adds a better error message when the directory given to --cwd doesn't exist.

How did you verify your code works?

added tests

@github-actions

github-actions Bot commented May 19, 2024 •

Copy link
Copy Markdown
Contributor

❌ @dylan-conway, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧🖥 1 failing tests Linux x64 baseline

🐧🖥 1 failing tests Linux x64

🪟💻 9 failing tests Windows x64 baseline

🪟💻 10 failing tests Windows x64

View logs

@dylan-conway
dylan-conway marked this pull request as ready for review May 21, 2024 01:28
@dylan-conway
dylan-conway merged commit cabfca4 into main May 21, 2024
@dylan-conway
dylan-conway deleted the dylan/fix-adding-packages-in-workspaces branch May 21, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants