Skip to content

Allow fs.close with no callback - #10229

Merged
Jarred-Sumner merged 3 commits into
mainfrom
georgijs/close-one-arg
Apr 13, 2024
Merged

Jarred-Sumner merged 3 commits into
mainfrom
georgijs/close-one-arg

Conversation

@gvilums

@gvilums gvilums commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Allows fs.close to be called without a callback
Fixes #10224

How did you verify your code works?

A test in fs.test.ts

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Apr 12, 2024 •

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Apr 12, 2024 •

Copy link
Copy Markdown
Contributor

@Jarred-Sumner
Jarred-Sumner merged commit 472bd6c into main Apr 13, 2024
@Jarred-Sumner
Jarred-Sumner deleted the georgijs/close-one-arg branch April 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.close incorrectly handles its arguments

2 participants