Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync URL from WebKit + set ERR_MISSING_ARGS #10129

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Apr 9, 2024

What does this PR do?

  • Re-sync URL from WebKit, which should 1/2 the size of the JS URL object in memory
  • Sets ERR_MISSING_ARGS everywhere we throw createNotEnoughArguments

5%-ish perf improvement to new URL
image

How did you verify your code works?

There is a test

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Copy link
Member

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Jarred-Sumner Jarred-Sumner merged commit f5c8914 into main Apr 10, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/url-code branch April 10, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants