Repository navigation
Fix absolute patterns with glob - #10121
Merged
Merged
Conversation
Contributor
|
❌ @zackradisic 4 files with test failures on linux-x64-baseline:
|
Contributor
|
❌ @zackradisic 4 files with test failures on bun-darwin-aarch64:
|
Contributor
|
❌ @zackradisic 4 files with test failures on linux-x64:
|
Contributor
|
❌ @zackradisic 4 files with test failures on bun-darwin-x64:
|
| expect(entries).toContain("README.md"); | ||
| }); | ||
|
|
||
| test("absolute path pattern should ignore cwd and start at the proper path", async () => { |
Collaborator
There was a problem hiding this comment.
can we get more tests for this? is there a way to run all the tests that run against relative paths to also run against absolute paths?
Collaborator
|
tests timed out on Windows |
Contributor
|
❌ @zackradisic 14 files with test failures on bun-windows-x86_64-haswell
|
Collaborator
|
conflict |
Collaborator
|
glob scan test is failing |
| if (pattern[component.start + component.len -| 1] == '/') { | ||
| component.trailing_sep = true; | ||
| } else if (comptime bun.Environment.isWindows) { | ||
| component.trailing_sep = pattern[component.start + component.len -| 1] == '\\'; |
Collaborator
There was a problem hiding this comment.
This should probably be any separator instead of specifically \
Contributor
Collaborator
|
@zackradisic the next step for this PR is to fix the failing scan test |
| // `/Users/zackradisic/foo/bar` | ||
| // In that case we don't need to do any walking and can just open up the FS entry | ||
| if (component_idx >= this.walker.patternComponents.items.len) { | ||
| const path = try this.walker.arena.allocator().dupeZ(u8, path_without_special_syntax); |
Collaborator
There was a problem hiding this comment.
does this need to be duplicated twice
Collaborator
|
one nitpicky comment but lets merge |
| return Maybe(void).success; | ||
| } | ||
| const errpath = try this.walker.arena.allocator().dupeZ(u8, path); | ||
| return .{ .err = e.withPath(errpath) }; |
Collaborator
There was a problem hiding this comment.
I suspect there will be more errors to ignore here. Like EPERM, EACCESS, EBUSY etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a bug where absolute patterns with Bun.Glob were not working
Fixes #8304
How did you verify your code works?
I included a test for the new code, or existing tests cover it
I ran my tests locally and they pass (
bun-debug test test-file-name.test)I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
I included a test for the new code, or an existing test covers it
JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
I wrote TypeScript/JavaScript tests and they pass locally (
bun-debug test test-file-name.test)