Skip to content

[JSC] The inline cache of a DFG/FTL global variable read throws when the property is gone - #908

Open
robobun wants to merge 2 commits into
mainfrom
robobun/0767d4fc/dfg-global-read-not-found
Open

[JSC] The inline cache of a DFG/FTL global variable read throws when the property is gone#908
robobun wants to merge 2 commits into
mainfrom
robobun/0767d4fc/dfg-global-read-not-found

[JSC] A GetByIdThrowIfNotFound cache that gives up drops its cases

edd7475
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 26, 2026 in 15m 53s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit Source/JavaScriptCore/bytecode/Repatch.cpp:813 Hot DFG/FTL reads of a global name whose site has cached 8 structures now call C++ on every later read, even once the gl
View more details on Claude