Repository navigation
Upgrade to upstream WebKit 33ce3bf11a71 - #860
Code review found 1 important issue
Found 2 candidates, confirmed 1. See review comments for details.
This review did not follow any REVIEW.md files in this repository's folders or any CLAUDE.md files, and did not see the pull request's title or description, because it could not get the full list of files this pull request changes. This can happen on a very large pull request. This pull request changes so many files that the review planned its work from the changed folders, not from the full list of files, and may have looked less closely at some files. Pull requests that change fewer than 300 files avoid this.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | Source/WebCore/dom/Document.cpp:10627 |
Pages without a body element (SVG, XML, XHTML before body) now get null from document.activeElement where the base branc |
Annotations
Check failure on line 10627 in Source/WebCore/dom/Document.cpp
claude / Claude Code Review
Pages without a body element (SVG, XML, XHTML before body) now get null from document.activeElement where the base branch returned the document element. Document::activeElement at Document.cpp:10627 returns bodyOrFrameset() and drops the documentElement()
Pages without a body element (SVG, XML, XHTML before body) now get null from document.activeElement where the base branch returned the document element. Document::activeElement at Document.cpp:10627 returns bodyOrFrameset() and drops the documentElement() fallback, so when no element is focused and there is no body the result is null. The HTML spec step 6 returns the document element in that case, and the diff turns the WPT svg/struct/scripted/autofocus-attribute.svg third case from PASS to FAIL