Skip to content

[JSC] addErrorInfo() drops what the host's stack formatter throws #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sosukesuzuki merged 1 commit into from
Oct 6, 2026
Merged

[JSC] addErrorInfo() drops what the host's stack formatter throws #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Source/JavaScriptCore/runtime/Error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,14 +267,19 @@ JSObject* addErrorInfo(VM& vm, JSObject* error, int line, const SourceCode& sour
if (!sourceURL.isEmpty()) {
errorInstance->setSourceURL(sourceURL);
}
#endif

errorInstance->materializeErrorInfoIfNeeded(vm);

#if USE(BUN_JSC_ADDITIONS)
if (hostComputes)
if (hostComputes) {
// The host's formatter can run user code (Error.prepareStackTrace), so it can throw. The caller made this
// error to throw it, or to hand it to someone who does, and expects no exception from here: what the
// formatter threw is dropped, short of a termination.
auto catchScope = DECLARE_TOP_EXCEPTION_SCOPE(vm);
errorInstance->materializeErrorInfoIfNeeded(vm);
catchScope.clearExceptionExceptTermination();
return errorInstance;
}
#endif

errorInstance->materializeErrorInfoIfNeeded(vm);
}

// Without such a host, materializing takes line and sourceURL from the top frame of the stack (the caller of eval or
Expand Down
Loading