Repository navigation
[JSC] Run a CommonJS module's generator before its importing graph links, not when its fetch completes #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Guard the deferred provider API with
USE(BUN_JSC_ADDITIONS).createDeferred(),isDeferred(), andm_isDeferredimplement Bun-specific module loading behavior. Wrap all three declarations with#if USE(BUN_JSC_ADDITIONS).As per coding guidelines: “Guard Bun-specific features with USE(BUN_JSC_ADDITIONS).”
Also applies to: 259-259
🤖 Prompt for AI Agents
Source: Coding guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changing this one. The whole
SyntheticSourceProviderclass is a Bun addition and none of it is guarded in this header, includingcreateWithLazyExports()andLazySyntheticSourceGeneratordirectly above. Guarding only these three members would make the class inconsistent with itself. Everything that uses them (makeModule(),SyntheticModuleRecord,AbstractModuleRecord::link()) is behindUSE(BUN_JSC_ADDITIONS).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 863
@dylan-conway, I could not verify the call-site guard context because repository access failed.The provided header confirms that related
SyntheticSourceProviderextensions are also unguarded. However, I cannot confirm that all deferred API uses are behindUSE(BUN_JSC_ADDITIONS)from the available evidence. Please retry the verification when repository access is available.You are interacting with an AI system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked: all 23 uses of the deferred API outside
SourceProvider.h(createDeferred/isDeferred,createWithDeferredGenerator,runDeferredGenerator,generateDeferredSyntheticModules,m_deferredGenerator*) inJSModuleLoader.cpp,SyntheticModuleRecord.{h,cpp}andAbstractModuleRecord.{h,cpp}sit inside#if USE(BUN_JSC_ADDITIONS); none is unguarded. So a build without the flag never references these members, the same as for the unguardedcreateWithLazyExports()next to them. Leaving the header as is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 1143
@dylan-conway, the repository verification failed because the sandbox could not clone the repository.Your explanation is consistent with the unguarded adjacent
createWithLazyExports()API and with the stated guard scopes. However, I could not independently verify theUSE(BUN_JSC_ADDITIONS)boundaries for all deferred API uses. The finding remains open until verification succeeds.✏️ Learnings added
🧠 Learnings used
You are interacting with an AI system.