Skip to content

[JSC] TypedArray indexOf/lastIndexOf/includes: an int32 needle that a Float16Array or Float32Array cannot hold exactly matches nothing - #604

Closed
robobun wants to merge 1 commit into
mainfrom
robobun/b68345e0/typed-array-indexof-int32-needle
Closed

robobun wants to merge 1 commit into
mainfrom
robobun/b68345e0/typed-array-indexof-int32-needle

[JSC] TypedArray indexOf/lastIndexOf/includes: an int32 needle that a…

a9c8309
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 8, 2026 in 9m 38s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit JSTests/stress/typed-array-index-of-int32-needle-not-representable.js:89 New stress test hardcodes '1e3' iterations instead of using 'testLoopCount', violating JSTests/README.md rule 2 (importe