Skip to content

CodeCache: keep unlinked code blocks decoded from cached bytecode in the in-memory cache #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-conway merged 5 commits into from
Aug 25, 2026
Merged

CodeCache: keep unlinked code blocks decoded from cached bytecode in the in-memory cache #513

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c7e09a
CodeCache: keep unlinked code blocks decoded from cached bytecode in …
dylan-conway Aug 24, 2026
539d0b4
Merge remote-tracking branch 'origin/main' into claude/codecache-reme…
dylan-conway Aug 24, 2026
cb5ca7c
Merge remote-tracking branch 'origin/main' into claude/codecache-reme…
dylan-conway Aug 25, 2026
870dee9
Do the insert next to the generate path's: findCacheAndUpdateAge is a…
dylan-conway Aug 25, 2026
f3475ef
Back to the minimal form: upstream's findCacheAndUpdateAge unchanged …
dylan-conway Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Source/JavaScriptCore/runtime/CodeCache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,15 @@ class CodeCacheMap {
prune();

iterator findResult = m_map.find(key);
if (findResult == m_map.end())
return fetchFromDisk<UnlinkedCodeBlockType>(vm, key);
if (findResult == m_map.end()) {
// A block decoded from the provider's cached bytecode is as reusable as one we generated: remember it the
// way getUnlinkedGlobalCodeBlock() remembers those, so another global in this VM loading the same source
// links against this block instead of decoding its own copy of the unlinked tree.
UnlinkedCodeBlockType* decoded = fetchFromDisk<UnlinkedCodeBlockType>(vm, key);
if (decoded && Options::useCodeCache())
addCache(key, SourceCodeValue(vm, decoded, m_age));
return decoded;
}

int64_t age = m_age - findResult->value.age;
if (age > m_capacity) {
Expand Down
Loading