Skip to content

Treat BunTranspiledModule as Module in debugger parse data, cached types and completion #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alii merged 2 commits into from
Aug 10, 2026
Merged

Treat BunTranspiledModule as Module in debugger parse data, cached types and completion #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e25722
fix breakpoints in bun transpiled modules
alii Aug 10, 2026
ff42fd0
avoid casting bun providers to string providers
alii Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Source/JavaScriptCore/debugger/DebuggerParseData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@ bool gatherDebuggerParseDataForSource(VM& vm, SourceProvider* provider, Debugger
case SourceProviderSourceType::Program:
return gatherDebuggerParseData<Program>(vm, completeSource, debuggerParseData);
case SourceProviderSourceType::Module:
#if USE(BUN_JSC_ADDITIONS)
case SourceProviderSourceType::BunTranspiledModule:
#endif
return gatherDebuggerParseData<Module>(vm, completeSource, debuggerParseData);
default:
return false;
Expand Down
15 changes: 15 additions & 0 deletions Source/JavaScriptCore/runtime/CachedTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,14 @@ class CachedStringSourceProvider : public CachedSourceProviderShape<StringSource
using Base = CachedSourceProviderShape<StringSourceProvider, CachedStringSourceProvider>;

public:
#if USE(BUN_JSC_ADDITIONS)
// Takes the base type for the same reason decode() returns it: Bun's runtime
// provider is a SourceProvider sibling of StringSourceProvider, and only
// base-class API is used below.
void encode(Encoder& encoder, const SourceProvider& sourceProvider)
#else
void encode(Encoder& encoder, const StringSourceProvider& sourceProvider)
#endif
{
Base::encode(encoder, sourceProvider);
#if USE(BUN_JSC_ADDITIONS)
Expand Down Expand Up @@ -1744,7 +1751,12 @@ class CachedSourceProvider : public VariableLengthObject<SourceProvider> {
switch (m_sourceType) {
case SourceProviderSourceType::Program:
case SourceProviderSourceType::Module:
#if USE(BUN_JSC_ADDITIONS)
case SourceProviderSourceType::BunTranspiledModule:
this->allocate<CachedStringSourceProvider>(encoder)->encode(encoder, sourceProvider);
#else
this->allocate<CachedStringSourceProvider>(encoder)->encode(encoder, reinterpret_cast<const StringSourceProvider&>(sourceProvider));
Comment thread
alii marked this conversation as resolved.
#endif
break;
#if ENABLE(WEBASSEMBLY)
case SourceProviderSourceType::WebAssembly:
Expand All @@ -1761,6 +1773,9 @@ class CachedSourceProvider : public VariableLengthObject<SourceProvider> {
switch (m_sourceType) {
case SourceProviderSourceType::Program:
case SourceProviderSourceType::Module:
#if USE(BUN_JSC_ADDITIONS)
case SourceProviderSourceType::BunTranspiledModule:
#endif
return this->buffer<CachedStringSourceProvider>()->decode(decoder, m_sourceType);
#if ENABLE(WEBASSEMBLY)
case SourceProviderSourceType::WebAssembly:
Expand Down
3 changes: 3 additions & 0 deletions Source/JavaScriptCore/runtime/Completion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ static ScriptFetchParameters::Type getSourceType(const SourceCode& source)
case SourceProviderSourceType::WebAssembly:
return ScriptFetchParameters::Type::WebAssembly;
case SourceProviderSourceType::Module:
#if USE(BUN_JSC_ADDITIONS)
case SourceProviderSourceType::BunTranspiledModule:
#endif
return ScriptFetchParameters::Type::JavaScript;
default:
return ScriptFetchParameters::Type::None;
Expand Down
Loading