Skip to content

JSModuleLoader: propagate a TerminationException from resolve() instead of treating it as a resolution failure #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-conway merged 1 commit into from
Aug 7, 2026
Merged

JSModuleLoader: propagate a TerminationException from resolve() instead of treating it as a resolution failure #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Source/JavaScriptCore/runtime/JSModuleLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,11 @@ JSPromise* JSModuleLoader::hostLoadImportedModule(JSGlobalObject* globalObject,
resolved = resolve(globalObject, specifier, referrerKey, scriptFetcher, useImportMap);
// 9. If the previous step threw an exception, then:
if (Exception* resolutionError = scope.exception()) {
// A TerminationException is not a resolution failure: it can be neither cleared
// (rejectWithCaughtException leaves it pending) nor cached, so let it propagate
// instead of continuing into FinishLoadingImportedModule with it still set.
if (vm.isTerminationException(resolutionError)) [[unlikely]]
RELEASE_AND_RETURN(scope, nullptr);
attachErrorInfo(globalObject, resolutionError, nullptr, specifier, moduleRequest.type(), ModuleFailure::Kind::Instantiation);
// Cache the resolution error so subsequent calls for the same specifier return the same error object.
JSValue errorValue = resolutionError->value();
Expand Down
Loading