Skip to content

SignalsWin: fix VEH return value and register behind AddressSanitizer's handler #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-conway merged 3 commits into from
Jul 24, 2026
Merged

SignalsWin: fix VEH return value and register behind AddressSanitizer's handler #331

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dadaeb
SignalsWin: return EXCEPTION_CONTINUE_SEARCH when no handler claims t…
robobun Jul 24, 2026
c8caa99
shorten comment
robobun Jul 24, 2026
13894c7
SignalsWin: register the vectored handler behind AddressSanitizer's
dylan-conway Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Source/WTF/wtf/win/SignalsWin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ LONG WINAPI vectoredHandler(struct _EXCEPTION_POINTERS *exceptionInfo)

PlatformRegisters& registers = *(exceptionInfo->ContextRecord);

long result = EXCEPTION_EXECUTE_HANDLER;
// A vectored handler may only return EXCEPTION_CONTINUE_EXECUTION or EXCEPTION_CONTINUE_SEARCH.
// Default to search so faults no handler claims proceed down the chain (e.g. to ASan's shadow
// committer) instead of looping on the faulting instruction; matches the POSIX/Mach NotHandled path.
long result = EXCEPTION_CONTINUE_SEARCH;
handlers.forEachHandler(signal, [&] (const SignalHandler& handler) {
switch (handler(signal, sigInfo, registers)) {
case SignalAction::Handled:
Expand Down
Loading