Skip to content

JSModuleNamespaceObject: expose the __esModule marker as an own property - #279

Open
robobun wants to merge 1 commit into
mainfrom
farm/379092be/esmodule-own-property
Open

robobun wants to merge 1 commit into
mainfrom
farm/379092be/esmodule-own-property

JSModuleNamespaceObject: expose the __esModule marker as an own property

c28e418
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 8, 2026 in 15m 2s

Code review found 1 new issue (1 earlier finding still open)

Found 1 candidates, confirmed 2: 1 posted in this review, 1 from earlier reviews still open. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 2
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp:393 'defineOwnProperty' returns 'true' for any truthy-value data descriptor on '__esModule' without validating the requested