fix(conductor): pass through sessionKeyPrefix from portable spawn result - #425
Closed
waylonkenning wants to merge 1 commit into
Closed
fix(conductor): pass through sessionKeyPrefix from portable spawn result#425waylonkenning wants to merge 1 commit into
waylonkenning wants to merge 1 commit into
Conversation
sessionKeyPrefix was hardcoded to null in conductor-spawn.ts, breaking async session resolution when the dashboard backend returns a prefix. Now mirrors the sessionKey pattern and passes through the value from the spawn result. Co-authored-by: Hermes Agent
Owner
|
Closing as superseded by #432. The validated fix was folded into the consolidated batch branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
sessionKeyPrefixwas hardcoded tonullinconductor-spawn.ts, breaking async session resolution when the dashboard backend returns a prefix value from the spawn result.Change
conductor-spawn.ts: ChangedsessionKeyPrefix: nullto read the value from the spawn result:(result as Record<string, unknown>).sessionKeyPrefix ?? nullThis mirrors the existing
sessionKeypattern and ensures the downstream job/session routing can correctly resolve sessions when the backend provides a prefix.How it was found
After getting the Conductor page working locally with a dashboard-backed backend, missions were spawning but the async session resolver could not find them because the hardcoded
nullblocked prefix-based lookups.Co-authored-by: Hermes Agent