fix(terminal): Docker-safe default cwd and missing-path fallback - #409
Closed
Norema19 wants to merge 4 commits into
Closed
fix(terminal): Docker-safe default cwd and missing-path fallback#409Norema19 wants to merge 4 commits into
Norema19 wants to merge 4 commits into
Conversation
PTY helper chdir fails when ~/.hermes is absent (common in Docker). Default shell cwd to home; server falls back to HOME if cwd does not exist. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace module-load BEARER_TOKEN with getGatewayBearerToken() so HERMES_API_TOKEN is honored after SSR/env hydration. Update routes and tests; terminal/pty hardening unchanged in this commit batch. Co-authored-by: Cursor <cursoragent@cursor.com>
Prefer GET /api/auth/session-token over HTML scrape so workspace ↔ hermes-dashboard works reliably in split-container Compose. Export looksLikeAuthFailure; narrow chat connection banner auth heuristics and clarify gateway vs dashboard env hints. Add Vitest for API-first path. Co-authored-by: Cursor <cursoragent@cursor.com>
Merge dashboard session-token API fix into main.
Owner
|
Closing as superseded by #432. The validated fix was folded into the consolidated batch branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The embedded terminal defaulted to
~/.hermes. In the workspace container, that expands to a path under passwd HOME (e.g./home/workspace/.hermes) that is often absent, sopty-helper.pyfails onos.chdirand the UI reconnects in a loop.Changes
~instead of~/.hermes.terminal-sessions.ts, if the resolved cwd does not exist, fall back toHOME.Note
Ocass Coolify compose sets
HOME=/opt/dataonhermes-workspaceso~is a real persisted directory.