fix(settings): wire provider OAuth, add canonical hermes-config API - #399
Closed
Dak0verflow wants to merge 3 commits into
Closed
fix(settings): wire provider OAuth, add canonical hermes-config API#399Dak0verflow wants to merge 3 commits into
Dak0verflow wants to merge 3 commits into
Conversation
Dak0verflow
marked this pull request as draft
May 8, 2026 23:18
Dak0verflow
marked this pull request as ready for review
May 8, 2026 23:56
Owner
|
Closing as superseded by #432. The validated fix was folded into the consolidated batch branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/hermes-configwith explicit patch actions:set-default-model,set-api-key,remove-api-key,set-custom-provider,remove-custom-provider. Backed bysrc/server/hermes-config-store.ts(path resolution, env IO, action handlers) andsrc/server/hermes-config-migration.ts(config-shape normalizer)./api/claude-configbecomes a thin alias on the same handlers insrc/server/hermes-config-route.ts.provider.maskedKeysis aliased from the newprovider.maskedCredentialsso the existing/settingspage keeps rendering./api/oauth/device-codeand/api/oauth/poll-tokendelegate todashboardFetch('/api/providers/oauth/{provider}/...')instead of the hardcoded Nous-portal path. Any provider the dashboard registers now works through the WebUI device-code flow.Set as default: {provider} · {model}button that renders only when the previewed selection differs from the saved default. Adds the OAuth device-code detail panel, the local-provider detail (detection status + discovered models), and a Model row to the Custom endpoint section./api/connection-statuspasses throughcapabilities.mcpFallback.Default model updated.,API key saved., etc.). Drops the blanketRestart Claude/Hermes to apply changes.copy.Test plan
pnpm exec vitest run src/server/hermes-config-*.test.ts src/routes/api/-hermes-config.test.ts src/routes/api/-oauth.test.ts src/routes/api/-connection-status.test.ts src/components/settings-dialog/settings-dialog.test.tsxManual:
auto→ clickSet as default: openrouter · auto→ next chat uses it.