fix(chat): clear stale thinking runs reliably - #397
Closed
Niko96-dotcom wants to merge 1 commit into
Closed
Conversation
Owner
|
Closing as superseded by #432. The validated fix was folded into the consolidated batch branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completerun statuses as terminal in the active-run polling fallback.Tests
pnpm test src/screens/chat/chat-screen-utils.test.ts src/server/run-store.test.tspnpm buildNote: I also ran the full
pnpm testlocally; it currently fails in unrelated existing suites on current main (MCP hub search expectations, gateway env resolution, i18n label text, context usage helper export, composer/context copy checks, chat-message-list helpers, and playground localStorage setup). This patch-specific coverage passes.