- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
demo app for settings opener example #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            livotov
  wants to merge
  18
  commits into
  feature/oskit-compose-4.1.0
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
dev/settings_screen_opener_example
  
      
      
   
  
    
  
  
  
 
  
      
    base: feature/oskit-compose-4.1.0
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            demo app for settings opener example #1
                    livotov
  wants to merge
  18
  commits into
  feature/oskit-compose-4.1.0
from
dev/settings_screen_opener_example
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    ryanmitchener
  
              
              requested changes
              
                  
                    May 16, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change the branch this is merging into to release/4.1.0 and merge that branch into this one. Also, please show the outcome under the buttons and you can remove the "pop back to home" button.
…o dev/settings_screen_opener_example # Conflicts: # composeApp/src/androidMain/kotlin/PlatformDI.kt # composeApp/src/commonMain/kotlin/DI.kt # composeApp/src/commonMain/kotlin/coordinator/AppCoordinator.kt # composeApp/src/commonMain/kotlin/ui/Route.kt # composeApp/src/commonMain/kotlin/ui/app/App.kt # composeApp/src/commonMain/kotlin/ui/home/HomeScreen.kt # composeApp/src/commonMain/kotlin/ui/home/HomeViewInteractor.kt # composeApp/src/desktopMain/kotlin/PlatformDI.kt # composeApp/src/iosMain/kotlin/PlatformDI.kt # composeApp/src/wasmJsMain/kotlin/PlatformDI.kt
…pener_example # Conflicts: # composeApp/src/commonMain/kotlin/coordinator/AppCoordinator.kt # composeApp/src/commonMain/kotlin/ui/Route.kt # composeApp/src/commonMain/kotlin/ui/app/App.kt # composeApp/src/commonMain/kotlin/ui/home/HomeScreen.kt # composeApp/src/commonMain/kotlin/ui/home/HomeViewInteractor.kt
…pener_example # Conflicts: # iosApp/Podfile.lock # iosApp/iosApp.xcodeproj/project.pbxproj
…pener_example # Conflicts: # composeApp/src/commonMain/kotlin/ui/home/HomeScreen.kt
              
                    ryanmitchener
  
              
              requested changes
              
                  
                    May 19, 2025 
                  
              
              
            
            
        
          
                composeApp/src/commonMain/kotlin/ui/settingsOpenerExample/SettingsOpenerExampleScreen.kt
          
            Show resolved
            Hide resolved
        
              
          
                composeApp/src/commonMain/kotlin/ui/settingsOpenerExample/SettingsOpenerExampleScreen.kt
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …le' into dev/settings_screen_opener_example
…pener_example # Conflicts: # composeApp/src/commonMain/kotlin/ui/app/App.kt # composeApp/src/commonMain/kotlin/ui/home/HomeScreen.kt # composeApp/src/commonMain/kotlin/ui/home/HomeViewInteractor.kt
              
                    ryanmitchener
  
              
              approved these changes
              
                  
                    Jun 17, 2025 
                  
              
              
            
            
…pener_example # Conflicts: # gradle/libs.versions.toml
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
No description provided.