feat: add optional authorization at page level #165
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been using this package for a bit and was having issues with using the settings globally, but also restricting access to some of the pages.
I added an
authorization
parameter to theaddSettingsFields
methods and used it to filter the pages on the Nova side. That way the settings are available outside Nova, but still restricted to people with permission. There is also a config for whether the default should be to hide or show ifauthorization
is null.Let me know if you think it's useful or if there's anything that I should change. No worries if it's too far out of scope for the project. Thanks!