Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Localization #61

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Better Localization #61

merged 2 commits into from
Aug 6, 2023

Conversation

FaridAghili
Copy link
Contributor

  1. Added Persian language support.
  2. Add RTL support

To implement RTL (Right-to-Left) support, I utilized the postcss-rtlcss package (as used in Nova). This approach ensures that all feature asset builds automatically generates both RTL and LTR styles whenever necessary.

@@ -16,6 +16,7 @@
"laravel-mix": "^6.0.49",
"postcss": "^8.4.18",
"postcss-import": "^15.0.0",
"postcss-rtlcss": "^3.6.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same version as used in Nova.

@FaridAghili
Copy link
Contributor Author

This change has been fully tested on a real-life project.

It doesn't affect LTR users, at all.

@richard-raadi
Copy link
Contributor

Tested in Persian & validated everything stays the same in LTR.

I will release this in the coming week.

Thanks for the contribution.

br,
RR

@richard-raadi richard-raadi merged commit e45c525 into outl1ne:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants