Prepare for release 1.6.3. #107
Conversation
dnkoutso
force-pushed
the
release.1.6.3
branch
from
05240b7
to
2e15a47
Compare
dnkoutso
force-pushed
the
release.1.6.3
branch
from
2e15a47
to
b97da27
Compare
|
I did not know the PR actually publishes stuff. I fixed some stuff and pushed again. This caused 1.6.3 to have been released already by the first CI run and now the job fails. This also blocks GH release to happen and other post release tasks... |
|
@dnkoutso Pushing a PR does not release anything. It's the TAG you committed that caused the release. |
|
@kdubb ah :( argh |
|
You need to prepare the release PR, merge it and then push a tag against that revision that includes the release PR. |
|
It was maybe not clear from this https://github.com/outfoxx/swiftpoet/blob/main/RELEASING.md that the PR should merge on the CHANGELOG etc. Maybe I understood wrong though. |
|
Yeah RELEASING is wrong. It's my fault for not reading it thoroughly |
|
What can we do now? Should I just drop 1.6.3 and try 1.6.4? |
|
If 1.6.3 is unpublishable somehow, I doubt anyone is using it we can then restart the process |
|
@dnkoutso This release action succeeded https://github.com/outfoxx/swiftpoet/actions/runs/7273399996. All the follow up actions failed because this version already exists. So 1.6.3 made it out into the world and includes the fix you want (I think). I would say just merge this PR and although I don't thing it will try to release again, just cancel any "release" actions it creates. Note that you can let the "snapshot" release action run as normal. |
|
Sounds good, merged. |
|
Done. For posterity I updated GH releases to match 1.6.3 now as the latest release since that was a post-release task. |
No description provided.