[DAT-101] Clean up premint topics and declare them via config #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligustah
approved these changes
Mar 26, 2024
| @@ -59,7 +59,7 @@ impl PremintStorage { | |||
| VALUES (?, ?, ?, ?, ?, ?, ?) | |||
| "#, | |||
| metadata.id, | |||
| metadata.kind, | |||
| metadata.kind.0, | |||
There was a problem hiding this comment.
If I'm understanding this syntax correctly it would pull the first field from the PremintName struct/tuple. If other fields were added before it, that would break this one, right? Not sure what the convention is here, but in python we could use a NamedTuple here to make the intention clear.
There was a problem hiding this comment.
PremintName is a wrapper on the type String, in this case kind.0 just pulls the inner value of string since the outer type PremintName doesn't implement sqlx's traits required for storage via macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive premint types the user wants to listen to from envar config.
Each Premint type returns a commonly formatted topic for actions required