Clean up all but import warnings #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligustah
approved these changes
Apr 15, 2024
| @@ -27,23 +27,21 @@ where | |||
| .await | |||
| .map_err(|err| eyre::eyre!("Error calling contract: {:?}", err)) | |||
| .and_then(|response| { | |||
| T::abi_decode_returns(&**response, false) | |||
| T::abi_decode_returns(&response, false) | |||
There was a problem hiding this comment.
Does this change the behavior? I saw it used in another context where the double ** was apparently required
There was a problem hiding this comment.
I thought it did but turns out its redundant, the compiler is gonna take a a copy of the reference automatically
| @@ -25,7 +24,7 @@ pub struct Chains<N>(Vec<Chain>, Cache<String, Arc<ChainListProvider<N>>>) | |||
| where | |||
| N: Network; | |||
|
|
|||
| pub static CHAINS: Lazy<Chains<Ethereum>> = Lazy::new(|| Chains::new()); | |||
| pub static CHAINS: Lazy<Chains<Ethereum>> = Lazy::new(Chains::new); | |||
There was a problem hiding this comment.
Oh, nice. Didn't know that worked!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a bunch of compiler warnings