Use official chain list #14
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ligustah
force-pushed
the
rich-rule-evaluation-results
branch
from
dc6b11f to
7db9571
Compare
| pub parent: Option<Parent>, | ||
| } | ||
|
|
||
| async fn connect(url: &String) -> eyre::Result<Box<dyn Provider<Ethereum>>> { |
There was a problem hiding this comment.
nit: it might be better to do connect<T>(url: &String) -> eyre::Result<T> where T: Provider<E>, E: Ethereum
just so downstream doesnt have to use a boxed type for everything
There was a problem hiding this comment.
The on_builtin works with both http and ws urls, so the actual return type depends on the URL that is passed in. Don't think that can be typed without the box.
There was a problem hiding this comment.
you just use a generic for the network type (similar to how you use E: Ethereum in the first comment)
| } | ||
|
|
||
| impl Chain { | ||
| pub async fn get_rpc(&self, need_pub_sub: bool) -> eyre::Result<Box<dyn Provider<Ethereum>>> { |
| } | ||
|
|
||
| impl Chain { | ||
| pub async fn get_rpc(&self, need_pub_sub: bool) -> eyre::Result<Box<dyn Provider<Ethereum>>> { |
There was a problem hiding this comment.
We should cache here otherwise we'll create a WS connection each time this function is called
Using the official chain list we can easily create RPC clients for any of the chains. Can update in future to allow overwriting URLs for specific chains (e.g. using our internal proxy in our deployment instead of the public url)