Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cli option to (de)compress quietly #325

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

a-moreira
Copy link
Contributor

closes #294

@a-moreira a-moreira mentioned this pull request Dec 19, 2022
src/opts.rs Outdated Show resolved Hide resolved
Co-authored-by: João Marcos Bezerra <[email protected]>
@marcospb19
Copy link
Member

quoted from #294 (comment)

I wasn't sure if I should send the args.quiet from the main function down the code, like it's done with the question policty and file visibility or not. Let me know what you think pls

I think it's ok to have the argument being passed like this, eventually we'll refactor if it's a problem.

I want to do some local testing here before merging, so I'll be giving another review when possible.

Copy link
Member

@marcospb19 marcospb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and everything seems to be OK, just a problem with the flag not being global.

ouch --quiet compress ... # This always works
ouch compress --quiet ... # This only works with 'global = true'
ouch compress ... --quiet # This only works with 'global = true'

I'll fix this for --quiet and other flags too, but in another PR.

@marcospb19 marcospb19 merged commit 5d21895 into ouch-org:main Dec 24, 2022
@marcospb19
Copy link
Member

Thanks for the PR! 🎉 🎉 🎉

@a-moreira a-moreira deleted the feat/quiet branch December 25, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag -q/--quiet
2 participants