Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ouch to decompress archive into existing folder #321

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

a-moreira
Copy link
Contributor

closes #296

Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't ask recursively for files in subdirectories, but this also seems to the default behavior as mentioned in the original comment

@marcospb19
Copy link
Member

This doesn't ask recursively for files in subdirectories, but this also seems to the default behavior as mentioned in the original comment

From my tests it seems that it is asking recursively, however, there are some surprises when using --dir and triggering the smart unpack functionality.

With --dir the output is redirected to another folder, but if you're unpacking an archive with more than one file inside, it will unpack it inside of an extra nested folder.

I think you thought it was not asking to overwrite because it was unpacked on another folder, so no paths conflicted.

This is probably talk for another issue or PR, smart unpack should probably be disabled when --dir is present (or even completely removed from Ouch).


Thanks @a-moreira for your PR! 🎉 🎉 🎉

@marcospb19 marcospb19 merged commit 7b26af2 into ouch-org:main Dec 11, 2022
@a-moreira a-moreira deleted the issue-296 branch December 11, 2022 21:51
@marcospb19
Copy link
Member

marcospb19 commented Dec 17, 2022

@a-moreira I forgot to tell you to add an entry to CHANGELOG.md, I'll be making a commit with your name in there.

EDIT: #324.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Ouch to decompress an archive into an existing folder
3 participants