Check for EOF when asking questions #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like theres an issue with tests, might need to add |
when invoking Ouch from shell scripts, it is likely that questions will be left unanswered with EOF, this commit fixes Ouch interpreting EOF as Yes in Y/N questions
marcospb19
force-pushed
the
check-eof-when-asking-question
branch
from
b638c54
to
b3646d3
Compare
figsoda
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking Ouch from shell scripts, it is likely that questions will
be left unanswered with EOF, this PR adds a check to prevent Ouch
from interpreting EOF as Yes in Y/N questions.