Mark directories when compressing to zip regardless of their contents #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmaSd
changed the title
|
I'm not being able to reproduce this error, but I'm trying only with a single empty folder, how can I see it? The output here is the same for ouch and zip. I tried ouch in the latest master branch, as well as the PR branch. |
|
The folder has to be not empty mkdir a; touch a/b; ouch l a.zip and ouch l a_ouch.zip should show differently |
|
Right, sorry for that one, noticed the fix now. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this:
zipouch l dir.zip-> it outputs the dir name correctly (in blue)ouchouch l dir.zip-> it doesn't output the dir name, because it doesn't identify it as a directory