Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple eprintln fixes #226

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

Crypto-Spartan
Copy link
Contributor

I found 2 instances where ouch should be using eprintln instead of println and fixed them here.

@marcospb19 marcospb19 merged commit f40f40c into ouch-org:master Dec 9, 2021
@marcospb19
Copy link
Member

Have you reviewed all the usages of println and eprintln?

We had discussions previously about where output should be directed to, and then stuff changed, I think that these eprintln were left from previous decisions.

@marcospb19 marcospb19 added the bugfix Fixes an existing bug label Dec 9, 2021
@Crypto-Spartan
Copy link
Contributor Author

Crypto-Spartan commented Dec 9, 2021

I saw the issues with the discussion, notably #110 & #114.

The discussions in those issues talked about moving all output to stderr, even normal [INFO] outputs. In the 2 instances I changed, they should have been directed to stderr in the first place (since they were actual errors) but they were going to stdout instead. So this PR shouldn't have any impact on the other issues, AFAIK.

I believe that I reviewed all of the usages of print, println, & eprintln, but there is a chance that I missed one somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants