Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decompression overwritting files without asking and failing on directories #141

Conversation

SpyrosRoum
Copy link
Contributor

Closes #136

src/commands.rs Outdated Show resolved Hide resolved
@marcospb19 marcospb19 merged commit 73c1d9a into ouch-org:master Nov 2, 2021
@marcospb19
Copy link
Member

marcospb19 commented Nov 2, 2021

Awesome that you caught another bug in this, makes me wonder how many specific errors like this still exist in ouch...

@SpyrosRoum
Copy link
Contributor Author

With this out of the way I am thinking it might be time for a new release?
We have fixed many bugs, some of them pretty critical..

@SpyrosRoum SpyrosRoum deleted the fix-decompression-overwritting-files-without-asking branch November 2, 2021 12:00
@marcospb19
Copy link
Member

With this out of the way I am thinking it might be time for a new release?

Yeah, it's been a long time since I said I was going to make a new release, we had too many changes.

I'm not sure what to put in the changelog, I think I'll make it more organized after the 1.0 release.

@SpyrosRoum
Copy link
Contributor Author

I'm not sure what to put in the changelog, I think I'll make it more organized after the 1.0 release.

I haven't used it personally but take a look at realease-please, it looks perfect for that kind of thing

@marcospb19
Copy link
Member

I think it will get easier when ouch leaves the unstable stage, let's see, I'm not a huge fan of pushing extra requirements like the "conventionalcommits" because I prefer to keep it simple for people to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decompression error when folder already exists at the place of output file
2 participants