Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing docs #128

Merged
merged 6 commits into from
Oct 31, 2021
Merged

Add Missing docs #128

merged 6 commits into from
Oct 31, 2021

Conversation

GabrielSimonetto
Copy link
Collaborator

Resolves #32

Contrary to all belief, it wasn't that hard to insert docs everywhere, the only place where it was REALLY repetitive to do so was the errors.rs, so, I am allowing missing docs there.

The docs aren't incredible, but we can discuss how to make them better here, I discovered that creating good documentation is actually kinda hard because it requires that you understand what you are doing!

@marcospb19
Copy link
Member

marcospb19 commented Oct 31, 2021

Got some weird errors last commit, have no idea what's going on, will try to solve it tomorrow.

@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 31, 2021
@marcospb19 marcospb19 merged commit 272b306 into master Oct 31, 2021
@marcospb19 marcospb19 deleted the issue-32 branch November 2, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning to missing docs and solve all warnings.
2 participants